From: Antoine Jacquet <royale@zerezo.com>
To: Lamarque Vieira Souza <lamarque@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, video4linux-list@redhat.com
Subject: Re: [PATCH] Implement changing resolution on the fly for zr364xx driver
Date: Tue, 21 Jul 2009 16:29:54 +0200 [thread overview]
Message-ID: <4A65D0E2.4060108@zerezo.com> (raw)
In-Reply-To: <200907202046.43194.lamarque@gmail.com>
Hi,
> This patch implements changing resolution in zr364xx_vidioc_s_fmt_vid_cap for
> zr364xx driver. This version is synced with v4l-dvb as of 20/Jul/2009. Tested
> with Creative PC-CAM 880.
Nice, I successfully tested your patch with 2 compatible webcams.
From the users feedbacks I had before, it seems that some devices do
not support the 640x480 resolution, but I was not able to verify this
myself.
This is the only concern I have, since some users may think the driver
is not working if the application automatically switches to the maximum
resolution with an incompatible device.
> OBS: I had to increase MAX_FRAME_SIZE to prevent a hard crash in my notebook
> (caps lock blinking) when testing with mplayer, which automatically sets
> resolution to the maximum (640x480). Maybe we should add code to auto-detect
> frame size to prevent this kind of crash in the future.
Yes, I also had this issue before. I don't know what is the good
approach to determine the best size with JPEG compression.
I will push your changes to my tree and send a pull request to Mauro later.
Regards,
Antoine
--
Antoine "Royale" Jacquet
http://royale.zerezo.com
next prev parent reply other threads:[~2009-07-21 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 23:54 [PATCH] Implement V4L2_CAP_STREAMING for zr364xx driver Lamarque Vieira Souza
2009-07-16 12:59 ` Antoine Jacquet
2009-07-16 13:58 ` Lamarque Vieira Souza
2009-07-16 15:45 ` Mauro Carvalho Chehab
2009-07-16 15:56 ` Force driver to load (tcm825x) Jesko Schwarzer
2009-07-16 16:42 ` [PATCH] Implement V4L2_CAP_STREAMING for zr364xx driver Karicheri, Muralidharan
2009-07-16 20:09 ` Lamarque Vieira Souza
2009-07-17 23:50 ` Antoine Jacquet
2009-07-20 23:46 ` [PATCH] Implement changing resolution on the fly " Lamarque Vieira Souza
2009-07-21 14:29 ` Antoine Jacquet [this message]
2009-07-21 15:14 ` Lamarque Vieira Souza
2009-07-21 22:42 ` Lamarque Vieira Souza
2009-07-22 19:31 ` Antoine Jacquet
2009-07-22 19:54 ` Lamarque Vieira Souza
2009-07-22 23:58 ` Antoine Jacquet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A65D0E2.4060108@zerezo.com \
--to=royale@zerezo.com \
--cc=lamarque@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.