From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH] Input: gpio_keys - swtich to dev_pm_ops Date: Tue, 21 Jul 2009 18:58:03 +0300 Message-ID: <4A65E58B.6010406@compulab.co.il> References: <1248184750-22274-1-git-send-email-mike@compulab.co.il> <20090721154848.GB4352@dtor-d630.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from compulab.site5.com ([67.18.134.219]:41029 "EHLO compulab.co.il" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754070AbZGUP6G (ORCPT ); Tue, 21 Jul 2009 11:58:06 -0400 In-Reply-To: <20090721154848.GB4352@dtor-d630.eng.vmware.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org Dmitry Torokhov wrote: > Hi Mike, > > On Tue, Jul 21, 2009 at 04:59:10PM +0300, Mike Rapoport wrote: >> + >> +static struct dev_pm_ops gpio_keys_pm_ops = { >> + .suspend = gpio_keys_suspend, >> + .resume = gpio_keys_resume, >> +}; >> > > This is not 100% equivalent conversion since we are now only handling > s2r, not s2d.. My question though is whether we care or not... I doubt that systems that use gpio-keys ever supported s2d... If you apply it we'll know soon :) >> static struct platform_driver gpio_keys_device_driver = { >> .probe = gpio_keys_probe, >> - .remove = __devexit_p(gpio_keys_remove), >> - .suspend = gpio_keys_suspend, >> .resume = gpio_keys_resume, >> .driver = { >> .name = "gpio-keys", >> .owner = THIS_MODULE, >> + .pm = &gpio_keys_pm_ops, >> } >> }; >> > -- Sincerely yours, Mike.