From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MTMEA-0007UL-MG for mharc-grub-devel@gnu.org; Tue, 21 Jul 2009 16:46:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTME6-0007SQ-NK for grub-devel@gnu.org; Tue, 21 Jul 2009 16:46:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTME1-0007PF-MM for grub-devel@gnu.org; Tue, 21 Jul 2009 16:46:17 -0400 Received: from [199.232.76.173] (port=41721 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTME1-0007P9-DG for grub-devel@gnu.org; Tue, 21 Jul 2009 16:46:13 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:55372) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTME0-0005Ol-Vo for grub-devel@gnu.org; Tue, 21 Jul 2009 16:46:13 -0400 Received: by bwz19 with SMTP id 19so3537580bwz.42 for ; Tue, 21 Jul 2009 13:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=CUhN2HjnYa0pQkU6UvhxEFlzGDAncUZHgSLCNJa3rcI=; b=r55tr94USydOmpDZsGS0pvxIphcTfY04031fmvpEN8TjeY8hRsj3xGnz0YLY8kLZUy LLo6aaIA722iwuFSvpPF5Jj2k5ZgzfntyMIlzw/k9GOEtjzVhX7V6Zm/bjBc03yb/7tl H8gzPcr8yQQpPkWeoGDrkx2XuOIFckGeH/4Dw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=KUBFD33fWC3QPvfEoxBkLS8E6nJjqlbcdYhMHZOIQjHbs59TOdrT1tBmOggSEF1W1A FovhkNKksa/REgPrNxA5gUVxbI2Dvcfx099UXSEPrQ1DiGLmthvw4Jt5xcIA17H+hcsf EvsgPiF5f4nKWFUaaGOK5xHr/0+8thTCxyf7A= Received: by 10.103.11.5 with SMTP id o5mr57756mui.34.1248209171101; Tue, 21 Jul 2009 13:46:11 -0700 (PDT) Received: from ?192.168.1.100? (89.141.11.145.dyn.user.ono.com [89.141.11.145]) by mx.google.com with ESMTPS id w5sm30233644mue.4.2009.07.21.13.46.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 21 Jul 2009 13:46:09 -0700 (PDT) Message-ID: <4A660CE9.6040104@gmail.com> Date: Tue, 21 Jul 2009 20:46:01 +0200 From: =?ISO-8859-1?Q?Javier_Mart=EDn?= User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: The development of GRUB 2 References: <1248196443.27068.86.camel@mj> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] UUID support for UFS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 20:46:18 -0000 Vladimir 'phcoder' Serbinenko escribió: > On Tue, Jul 21, 2009 at 7:14 PM, Pavel Roskin wrote: >> On Tue, 2009-07-21 at 15:03 +0200, Vladimir 'phcoder' Serbinenko wrote: >>> + grub_sprintf (*uuid, "%08lx%08lx", >>> + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidhi), >>> + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidlow)); >> unsigned long is 64-bit on x86_64. unsigned int would do just fine >> here. > Ok We could use the macros for [u]intN_t types: grub_sprintf (*uuid, PRIx32 "-" PRIx32, grub_le_to_cpu32 (data->sblock.uuidhi), grub_le_to_cpu32 (data->sblock.uuidlow)); Of course, our *printf functions would have to recognize them, and we'd have to provide a suitable default for the header if the system compiler is not C99 compliant, but I think it's a good step forwards. I would be willing to implement such a header/change to the *printf functions if there's any interest in them.