All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: "Richard W.M. Jones" <rjones@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: guestfwd option doesn't allow supplementary   , server, nowait
Date: Tue, 21 Jul 2009 18:41:00 -0500	[thread overview]
Message-ID: <4A66520C.2010102@codemonkey.ws> (raw)
In-Reply-To: <4A664ACD.9070208@web.de>

Jan Kiszka wrote:
>> The syntax I proposed early for -drive could address this.
>>
>> -net user,name=foo,guestfwd=tcp:10.0.2.4:6666
>> -net.foo.guestfwd-arg unix:/some/path,server,nowait
>>
>>     
>
> I general yes, but I would rate this particular suggestion as a bad
> example for intuitive argument splitting (guestfwd is useless without a
> target like unix:/bla).

The throw an error.

-drive name=foo is also useless without a file= option.

>  If at all, we would have to push server and
> nowait into the additional args. Still, this requires more thoughts.
>   

Yes, the server and nowait options are unfortunate.  We should probably 
introduce mode=client|server and wait=on|off.   Best thing to do is 
completely swizzle the char device syntax.  Something like:

-char name=foo,type=unix,unix-path=/some/path,mode=server,wait=off

Then allow a char:<name> url to be used anywhere that takes traditional 
char device urls.

-net user,guestfwd=tcp:10.0.2.4:6666-char:foo

> Jan
>
>   
Regards,

Anthony Liguori

  reply	other threads:[~2009-07-21 23:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 14:39 [Qemu-devel] guestfwd option doesn't allow supplementary , server, nowait Richard W.M. Jones
2009-07-21 14:57 ` [Qemu-devel] " Richard W.M. Jones
2009-07-21 17:39 ` Jan Kiszka
2009-07-21 16:17   ` Richard W.M. Jones
2009-07-21 16:20     ` Jan Kiszka
2009-07-21 16:39       ` Richard W.M. Jones
2009-07-21 19:23       ` Richard W.M. Jones
2009-07-21 23:15         ` Jan Kiszka
2009-07-22  8:42           ` Richard W.M. Jones
2009-07-22  8:55             ` Jan Kiszka
2009-07-22  9:19               ` Richard W.M. Jones
2009-07-22  9:05             ` Richard W.M. Jones
2009-07-22  9:33               ` Jan Kiszka
2009-07-22  8:51           ` Jan Kiszka
2009-07-21 20:05   ` Anthony Liguori
2009-07-21 23:10     ` Jan Kiszka
2009-07-21 23:41       ` Anthony Liguori [this message]
2009-07-22  9:13         ` Gerd Hoffmann
2009-07-22  9:46           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A66520C.2010102@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.