From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MTbGI-0003SX-D2
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 08:49:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MTbGD-0003Rc-Mj
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 08:49:34 -0400
Received: from [199.232.76.173] (port=60100 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MTbGD-0003RY-FP
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 08:49:29 -0400
Received: from mail-yx0-f188.google.com ([209.85.210.188]:47365)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MTbGD-0002UO-0N
	for qemu-devel@nongnu.org; Wed, 22 Jul 2009 08:49:29 -0400
Received: by yxe26 with SMTP id 26so241418yxe.4
	for <qemu-devel@nongnu.org>; Wed, 22 Jul 2009 05:49:28 -0700 (PDT)
Message-ID: <4A670AD5.7080700@codemonkey.ws>
Date: Wed, 22 Jul 2009 07:49:25 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] qdev/pci: hook up i440fx.
References: <1248180900-16242-1-git-send-email-kraxel@redhat.com>
	<1248180900-16242-3-git-send-email-kraxel@redhat.com>
In-Reply-To: <1248180900-16242-3-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> Hook i44fx pcihost into sysbus.
> Convert Host bridge and ISA bridge pci devices to qdev.
> Tag as no-user.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
I get an immediate SEGV with this patch:

#0  strlen () at ../sysdeps/x86_64/strlen.S:48
#1  0x00000000004698cb in qemu_strdup (str=0x0)
    at /home/anthony/git/qemu/qemu-malloc.c:76
#2  0x00000000004aeb9c in qbus_create (info=0x8132e0, parent=0x1fb8010,
    name=0x0) at /home/anthony/git/qemu/hw/qdev.c:239
#3  0x0000000000415a62 in pci_register_bus (parent=<value optimized out>,
    name=<value optimized out>, set_irq=0x463300 <piix3_set_irq>, 
map_irq=0,
    pic=0xfefefefefefefeff, devfn_min=2097152, nirq=4)
    at /home/anthony/git/qemu/hw/pci.c:134
#4  0x00000000004632b9 in i440fx_init (pi440fx_state=0xb9ab08, 
pic=0x1f4f5c0)
    at /home/anthony/git/qemu/hw/piix_pci.c:210
#5  0x0000000000447898 in pc_init1 (ram_size=<value optimized out>,
    boot_device=0x7fffaddd1670 "cad", kernel_filename=0x571e4c "ne2k_pci",
    kernel_cmdline=0x5b06eb "", initrd_filename=0x0,
    cpu_model=<value optimized out>, pci_enabled=1, compat_level=0)
    at /home/anthony/git/qemu/hw/pc.c:1277
#6  0x0000000000447c58 in pc_init_pci (ram_size=0, boot_device=0x0,
    kernel_filename=0x0, kernel_cmdline=0x0,
    initrd_filename=0xfefefefefefefeff <Address 0xfefefefefefefeff out 
of bounds>, cpu_model=0x200000 <Address 0x200000 out of bounds>)
    at /home/anthony/git/qemu/hw/pc.c:1474
#7  0x000000000040d983 in main (argc=6, argv=0x7fffaddd1808,
    envp=<value optimized out>) at /home/anthony/git/qemu/vl.c:5976

Regards,

Anthony Liguori