From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org,
Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>,
Taketoshi Sakuraba <taketoshi.sakuraba.hc@hitachi.com>
Subject: Re: [PATCH] x86, mce: Rename incorrect macro name "CONFIG_X86_THRESHOLD"
Date: Wed, 22 Jul 2009 07:16:52 -0700 [thread overview]
Message-ID: <4A671F54.7050101@zytor.com> (raw)
In-Reply-To: <4A671206.500@linux.intel.com>
On 07/22/2009 06:20 AM, Andi Kleen wrote:
>
>> It seems that this ifdef was introduced by the following merge commit:
>
> I also managed to introduce similar bugs during merges in the past.
> It's very easy and hard to find.
>
> Perhaps it would be good if we had some automated tool that checks
> all CONFIG_*s referenced exist in Kconfig and that is run regularly.
There is checkkconfigsymbols.sh...
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-07-22 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 2:56 [PATCH] x86, mce: Rename incorrect macro name "CONFIG_X86_THRESHOLD" Hidehiro Kawai
2009-07-22 3:37 ` Hidetoshi Seto
2009-07-22 13:20 ` Andi Kleen
2009-07-22 14:16 ` H. Peter Anvin [this message]
2009-07-22 5:25 ` [tip:x86/urgent] " tip-bot for Hidehiro Kawai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A671F54.7050101@zytor.com \
--to=hpa@zytor.com \
--cc=ak@linux.intel.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=taketoshi.sakuraba.hc@hitachi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.