From: Anthony Liguori <anthony@codemonkey.ws>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct
Date: Wed, 22 Jul 2009 11:22:22 -0500 [thread overview]
Message-ID: <4A673CBE.8040003@codemonkey.ws> (raw)
In-Reply-To: <1248278346.4521.5.camel@slab.beaverton.ibm.com>
Hollis Blanchard wrote:
> On Wed, 2009-07-22 at 10:34 -0500, Anthony Liguori wrote:
>
>> Alexander Graf wrote:
>>
>>> Some generic code tries to access env->mp_state. Let's just make
>>> it happy and provide it.
>>>
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>>
>>>
>> Or we can move that code from kvm-all.c to target-i386/kvm.c where it
>> belongs :-)
>>
>
> Common code uses mp_state, and i386 is the only thing calling that code.
> However, the ioctl used by that code is valid for all architectures; it
> will just return -EINVAL. Someday we might need it in common code, but
> then again it's not even clear to me it will be useful outside of x86.
>
> I'm fine with moving it too, as long as it's also renamed at the same
> time. :)
>
Why is it a common ioctl instead of an arch specific ioctl?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-07-22 16:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 11:51 [Qemu-devel] [PATCH 0/4] Add preliminary KVM support for non-embedded PPC v3 Alexander Graf
2009-07-17 11:51 ` [Qemu-devel] [PATCH 1/7] Enable PPC KVM for non-embedded Alexander Graf
2009-07-17 11:51 ` [Qemu-devel] [PATCH 2/7] Set PVR in sregs Alexander Graf
2009-07-17 11:51 ` [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct Alexander Graf
2009-07-17 11:51 ` [Qemu-devel] [PATCH 4/7] Fix warning in kvm-all.c Alexander Graf
2009-07-17 11:51 ` [Qemu-devel] [PATCH 5/7] Use correct input constant Alexander Graf
2009-07-17 11:51 ` [Qemu-devel] [PATCH 6/7] Set slots more carefully Alexander Graf
2009-07-17 11:51 ` [Qemu-devel] [PATCH 7/7] Fake dirty loggin when it's not there Alexander Graf
2009-07-17 12:10 ` Stefano Stabellini
2009-07-17 12:14 ` Alexander Graf
2009-07-17 12:18 ` Alexander Graf
2009-07-17 12:25 ` Stefano Stabellini
2009-07-17 12:27 ` Alexander Graf
2009-07-17 13:18 ` Stefano Stabellini
2009-07-17 13:23 ` Alexander Graf
2009-07-17 14:37 ` [Qemu-devel] " Jan Kiszka
2009-07-17 15:00 ` Alexander Graf
2009-07-17 15:47 ` Jan Kiszka
2009-07-17 13:48 ` [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully Jan Kiszka
2009-07-17 13:53 ` Alexander Graf
2009-07-17 14:18 ` Jan Kiszka
2009-07-17 14:23 ` Alexander Graf
2009-07-17 14:30 ` Jan Kiszka
2009-07-21 22:55 ` [Qemu-devel] " Anthony Liguori
2009-07-22 15:34 ` [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct Anthony Liguori
2009-07-22 15:59 ` Hollis Blanchard
2009-07-22 16:22 ` Anthony Liguori [this message]
2009-07-22 16:26 ` Hollis Blanchard
2009-07-22 16:51 ` [Qemu-devel] " Jan Kiszka
2009-07-22 18:11 ` Anthony Liguori
2009-07-22 19:11 ` Jan Kiszka
2009-07-21 22:36 ` [Qemu-devel] Re: [PATCH 0/4] Add preliminary KVM support for non-embedded PPC v3 Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A673CBE.8040003@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=hollisb@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.