From: Stephen Boyd <bebarino@gmail.com>
To: "Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v4] grep: Add --max-depth option.
Date: Wed, 22 Jul 2009 23:11:33 -0700 [thread overview]
Message-ID: <4A67FF15.7080703@gmail.com> (raw)
In-Reply-To: <1248285135-9033-1-git-send-email-michal.kiedrowicz@gmail.com>
This looks good now. Just one minor point but I don't think it requires
a resend.
Michał Kiedrowicz wrote:
>
> + { OPTION_INTEGER, 0, "max-depth", &opt.max_depth, "depth",
> + "descend at most <depth> levels", PARSE_OPT_NONEG,
> + NULL, 1 },
This NULL and 1 are not needed unless you're using PARSE_OPT_OPTARG. I
think this last line can be safely removed.
prev parent reply other threads:[~2009-07-23 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 17:52 [PATCH v4] grep: Add --max-depth option Michał Kiedrowicz
2009-07-22 18:44 ` Junio C Hamano
2009-07-23 6:11 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A67FF15.7080703@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michal.kiedrowicz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.