All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Ed Swierk <eswierk@aristanetworks.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] slirp: Remove our_addr code
Date: Thu, 23 Jul 2009 08:51:09 +0200	[thread overview]
Message-ID: <4A68085D.8000600@web.de> (raw)
In-Reply-To: <9ae48b020907221841q392c58b7k20f560f8a5e99fc2@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Ed Swierk wrote:
> On Thu, Jul 23, 2009 at 1:37 AM, Ed Swierk<eswierk@aristanetworks.com> wrote:
>> - It's useless: aside from the CU-SeeMe protocol emulation which I
>> propose removing, the only other reference is in get_dns_addr(), but
>> can't imagine why you would want to send DNS requests to a different IP
>> address if you're running a DNS server on the host and resolv.conf
>> points to 127.0.0.1.
>>
>> These problems are easily solved by removing the code.
> 
> Note that VirtualBox removed this code recently as well:
> http://www.virtualbox.org/ticket/1470 .

While I don't consider VirtualBox as a good reference for changing QEMU
code ;), the patch has my conditional ack (depending on the CUSEEME
emulation removal).

Thanks for picking all this up!
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

      reply	other threads:[~2009-07-23  6:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23  1:37 [Qemu-devel] [PATCH] slirp: Remove our_addr code Ed Swierk
2009-07-23  1:41 ` [Qemu-devel] " Ed Swierk
2009-07-23  6:51   ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A68085D.8000600@web.de \
    --to=jan.kiszka@web.de \
    --cc=eswierk@aristanetworks.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.