All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] document network driver framework
Date: Thu, 23 Jul 2009 15:14:25 -0700	[thread overview]
Message-ID: <4A68E0C1.2000605@gmail.com> (raw)
In-Reply-To: <20090723220650.74C9B832E416@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20090723214946.GE9480@game.jcrosoft.org> you wrote:
>   
>>> +And to control whether your driver is even enabled, you should use:
>>> +	CONFIG_SYS_NET_<DRIVERNAME>
>>>       
>> In my proposition CONFIG_SYS_ will be not use for driver enabling but for
>> hardware specific information
>>     
>
> Enabling or disabling a driver i ssomething that a dumb user can do,
> so it should be done using
>
> 	CONFIG_<DRIVERNAME>
>
> as in CONFIG_E1000, CONFIG_EEPRO100, etc.
>
>   
Fine with me, although I understand the argument that it doesn't convey 
enough information, especially when dealing with devices that are more 
obscure than Intel E1000.  CONFIG_SYS_APE is definitely wrong, I think 
CONFIG_NET_APE should be for networking features such as selectable 
protocols.  Maybe a compromise if one is needed would be 
CONFIG_NETDEV_APE ?  Or is it too verbose?

regards,
Ben

  reply	other threads:[~2009-07-23 22:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16  1:39 [U-Boot] eth/net driver documentation Mike Frysinger
2009-07-16 17:36 ` Ben Warren
2009-07-19  1:04   ` [U-Boot] [PATCH 1/2] net: rename NetRxPkt to NetRxPacket Mike Frysinger
2009-07-21  4:49     ` Ben Warren
2009-07-19  1:04   ` [U-Boot] [PATCH 2/2] document network driver framework Mike Frysinger
2009-07-21  5:09     ` Ben Warren
2009-07-21  6:28       ` Mike Frysinger
2009-07-21  7:32         ` Wolfgang Denk
2009-07-21 20:38           ` Mike Frysinger
2009-07-21 20:55             ` Ben Warren
2009-07-21 21:08               ` Mike Frysinger
2009-07-21  7:27       ` Wolfgang Denk
2009-07-22 23:00     ` Andy Fleming
2009-07-23  0:16       ` Mike Frysinger
2009-07-23 21:49     ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 22:06       ` Wolfgang Denk
2009-07-23 22:14         ` Ben Warren [this message]
2009-07-23 22:24           ` Wolfgang Denk
2009-09-09 18:41     ` [U-Boot] [PATCH v2] " Mike Frysinger
2009-09-22 18:34       ` Wolfgang Denk
2009-10-04 19:12       ` Wolfgang Denk
2009-10-04 22:07         ` Ben Warren
2009-10-05  6:05       ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A68E0C1.2000605@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.