[Qemu-devel] Re: [PATCH 3/3] PPC: Round VGA BIOS size to page boundary

[Jan Kiszka <jan.kiszka@siemens.com>]

Alexander Graf wrote:
> When giving KVM a slot of a size not on page boundary, it chokes. So let's
> just round up the VGA BIOS size so nobody complains anymore and we don't need
> to implement sub-page slots.
> 
> Required for booting a PPC guest in KVM.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  hw/ppc_newworld.c |    3 +++
>  hw/ppc_oldworld.c |    4 ++++
>  2 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c
> index 4e5043c..b28a23d 100644
> --- a/hw/ppc_newworld.c
> +++ b/hw/ppc_newworld.c
> @@ -179,6 +179,9 @@ static void ppc_core99_init (ram_addr_t ram_size,
>          vga_bios_ptr[3] = 'V';
>          cpu_to_be32w((uint32_t *)(vga_bios_ptr + 4), vga_bios_size);
>          vga_bios_size += 8;
> +
> +        /* Round to page boundary */
> +        vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) & TARGET_PAGE_MASK;

To be really nit-picky: ;)

(vga_bios_size + TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK;

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux