From: Eric Sandeen <sandeen@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andreas Dilger <adilger@sun.com>,
Ron Johnson <ron.l.johnson@cox.net>,
linux-ext4@vger.kernel.org
Subject: Re: ioctl32
Date: Fri, 24 Jul 2009 11:28:31 -0500 [thread overview]
Message-ID: <4A69E12F.2070904@redhat.com> (raw)
In-Reply-To: <87k51y11yn.fsf@basil.nowhere.org>
Andi Kleen wrote:
> Eric Sandeen <sandeen@redhat.com> writes:
>> /* pointer to compatible structure or no argument */
>> #define COMPATIBLE_IOCTL(cmd) \
>> { (cmd), do_ioctl32_pointer },
>
>
> The modern way to do this is to use the ->compat_ioctl VFS
> method. COMPATIBLE_IOCTL etc are all obsolete.
>
>> I think adding COMPATIBLE_IOCTL(FS_IOC_FIEMAP); to fs/compat_ioctl.c
>> should be enough, I'll try to get it tested tomorrow.
>
> Nope, add a ->compat_ioctl
>
> When your ioctl is already a unlocked_ioctl you can just use
> the same function. If not convert to unlocked_ioctl first.
>
> -Andi
Ok thanks, I knew I needed to revisit it. ;)
-Eric
next prev parent reply other threads:[~2009-07-24 16:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 21:49 filefrag abort Ron Johnson
2009-07-20 22:16 ` Eric Sandeen
2009-07-21 2:03 ` Theodore Tso
2009-07-22 0:33 ` ioctl32 (was Re: filefrag abort) Ron Johnson
2009-07-22 0:57 ` Eric Sandeen
2009-07-22 17:01 ` Andreas Dilger
2009-07-23 4:51 ` Eric Sandeen
2009-07-24 0:34 ` Ron Johnson
2009-07-24 2:38 ` Eric Sandeen
2009-07-24 16:26 ` ioctl32 Andi Kleen
2009-07-24 16:28 ` Eric Sandeen [this message]
2009-07-25 14:46 ` ioctl32 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A69E12F.2070904@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=andi@firstfloor.org \
--cc=linux-ext4@vger.kernel.org \
--cc=ron.l.johnson@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.