From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Christopher Li <sparse@chrisli.org>
Cc: Josh Triplett <josh@joshtriplett.org>,
Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 2/5] Fix some "enum value 'SYM_...' not handled in switch" warnings
Date: Fri, 24 Jul 2009 19:25:02 +0100 [thread overview]
Message-ID: <4A69FC7E.7020600@ramsay1.demon.co.uk> (raw)
In-Reply-To: <70318cbf0907211729j51e48ca0p430d898a5cb86bc8@mail.gmail.com>
Christopher Li wrote:
> OK. I don't want to list all the enumerate value here just for the
> sake of gcc warnings.
> It makes the code ugly. Nor do I want to change the gcc flags used to compile
> sparse. If the newest gcc still complain on those. I would rather add
> the blank default
> to make it clean. Since latest gcc doesn't issue warning on those. I
> think it is fine to
> leave it as it is.
>
OK, no problem. I can maintain this in my cygwin repo, along with the
__sentinel__ attribute patch. (As before, I don't need this on Linux).
Just FYI, I had planned to fix this by implementing a local makefile
config file (like config.mak in git), so that I could fix this issue
locally ("out of tree").
However, I was (pleasantly) surprised to find that I'd been beaten to
the punch by Samuel Bronson in commit 8d86d0e.
So I tried this local.mk file:
OS=cygwin
CFLAGS+=-Wno-switch-enum
This lead to the invocation of gcc I was hoping for; something like:
gcc ... -Wall ... -Wno-switch-enum parse.c
which I had expected to suppress the warnings. It didn't. *Ho-Hum* ;-)
ATB,
Ramsay Jones
next prev parent reply other threads:[~2009-07-24 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-18 20:41 [PATCH 2/5] Fix some "enum value 'SYM_...' not handled in switch" warnings Ramsay Jones
2009-07-19 14:01 ` Josh Triplett
2009-07-21 21:15 ` Ramsay Jones
2009-07-22 0:29 ` Christopher Li
2009-07-24 18:25 ` Ramsay Jones [this message]
2009-07-24 20:13 ` Christopher Li
2009-07-23 4:42 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A69FC7E.7020600@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.