Re: [PATCH] Input: gpio_keys - swtich to dev_pm_ops

[Mike Rapoport <mike@compulab.co.il>]

Dmitry Torokhov wrote:
> On Tue, Jul 21, 2009 at 06:58:03PM +0300, Mike Rapoport wrote:
>>
>> Dmitry Torokhov wrote:
>>> Hi Mike,
>>>
>>> On Tue, Jul 21, 2009 at 04:59:10PM +0300, Mike Rapoport wrote:
>>>> +
>>>> +static struct dev_pm_ops gpio_keys_pm_ops = {
>>>> +	.suspend	= gpio_keys_suspend,
>>>> +	.resume		= gpio_keys_resume,
>>>> +};
>>>>  
>>> This is not 100% equivalent conversion since we are now only handling
>>> s2r, not s2d.. My question though is whether we care or not...
>> I doubt that systems that use gpio-keys ever supported s2d...
>> If you apply it we'll know soon :)
>>
>>>>  static struct platform_driver gpio_keys_device_driver = {
>>>>  	.probe		= gpio_keys_probe,
>>>> -	.remove		= __devexit_p(gpio_keys_remove),
>>>> -	.suspend	= gpio_keys_suspend,
>>>>  	.resume		= gpio_keys_resume,
> 
> I don't think you tried compiling this patch ;( We still need the
> remove() method and I think we should keep the CONFIG_PM guards.

I did, just I have the gpio-keys built-in in my config, so .remove is not called ...

> I will fix locally.
> 

-- 
Sincerely yours,
Mike.