From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Sun, 26 Jul 2009 12:46:17 +0000 Subject: Re: [GIT PULL] Add KVM support for Book3s_64 (PPC64) hosts v3 Message-Id: <4A6C5019.5010905@redhat.com> List-Id: References: <1248453028-49627-1-git-send-email-agraf@suse.de> In-Reply-To: <1248453028-49627-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On 07/26/2009 03:26 PM, Alexander Graf wrote: > Cool, next week :-). The current version works fine without. And I > need a weekend for a change :-D. Having returned from a 10-day weekend, I can only recommend this. >> >> Yuck. What do we do? Implement set_bit_u64() and friends? > > > That's what I'd think we should do, yes. > > For qemu I sent a patch that always uses "uint64_t" because that works > fine with the current code (32-bit on 64-bit uses the right bytes for > LE, 64-bit on 64-bit doesn't change). PPC is not implement yet for > anyone either and for now we only have dirty logging with 64 bit > kernels and 32-bit or 64-bit userspace, so that's fine too. > > As soon as someone implement dirty logging on a 32-bit big endian > target, it will break though, so before that day comes we need to > change set_bit to set_bit_64. Perhaps we can get away with disabling 32-on-64 for the configurations that break to start with. -- error compiling committee.c: too many arguments to function