From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state Date: Sun, 26 Jul 2009 17:47:16 +0300 Message-ID: <4A6C6C74.4040808@redhat.com> References: <4A678A56.7050901@web.de> <20090723214553.GA10152@amt.cnet> <4A695C1D.7030807@web.de> <4A6C5F4B.2000902@redhat.com> <4A6C66F2.7010606@web.de> <4A6C69F5.3020604@redhat.com> <4A6C6A74.4030801@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34208 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753570AbZGZOmv (ORCPT ); Sun, 26 Jul 2009 10:42:51 -0400 In-Reply-To: <4A6C6A74.4030801@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 07/26/2009 05:38 PM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 07/26/2009 05:23 PM, Jan Kiszka wrote: >> >>>> btw, what does it fix? a debug warning? >>>> >>>> >>>> >>> I haven't seen anything in the wild, and I don't think it would raise a >>> warning. All it should cause is a potential delay of some pending >>> reschedule as preempt_enable will not fire under local_irq_disable. >>> >>> >> Ah, okay, then it is a real fix. Preempt-correctness is important. >> >> (but won't local_irq_enable() reschedule?) >> > > The last time I checked it was essentially a plain 'sti'. > > Presumably there's a reschedule interrupt queued; I think if you set the reschedule bit you have to IPI the cpu running the task. -- error compiling committee.c: too many arguments to function