From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_repair: check for null single-block dir buffer pointer in phase6
Date: Sun, 26 Jul 2009 17:52:28 -0500 [thread overview]
Message-ID: <4A6CDE2C.9070508@sandeen.net> (raw)
In-Reply-To: <20090725150256.GA12148@infradead.org>
Christoph Hellwig wrote:
> On Fri, Jul 24, 2009 at 09:34:08AM -0500, Eric Sandeen wrote:
>> @@ -2524,7 +2525,7 @@ longform_dir2_entry_check(xfs_mount_t *mp,
>>
>> if (!dotdot_update) {
>> /* check btree and freespace */
>> - if (isblock) {
>> + if (isblock && bplist[0]) {
>> xfs_dir2_block_tail_t *btp;
>> xfs_dir2_leaf_entry_t *blp;
>
> This doesn't look quite correct to me. Now we falls through to the
> final else statement when bplist[0] is zeroed.
>
Oh, ugh, you're right. Will fix that up, thanks.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-07-26 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 14:34 [PATCH] xfs_repair: check for null single-block dir buffer pointer in phase6 Eric Sandeen
2009-07-25 15:02 ` Christoph Hellwig
2009-07-26 22:52 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6CDE2C.9070508@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.