From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVQcW-0003EU-Ke for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:52:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVQcQ-00039h-Ri for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:52:02 -0400 Received: from [199.232.76.173] (port=55983 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVQcQ-00039M-DG for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:51:58 -0400 Received: from mail-qy0-f174.google.com ([209.85.221.174]:40999) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVQcP-000374-WC for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:51:58 -0400 Received: by qyk4 with SMTP id 4so3636817qyk.4 for ; Mon, 27 Jul 2009 06:51:57 -0700 (PDT) Message-ID: <4A6DB0FB.2060406@codemonkey.ws> Date: Mon, 27 Jul 2009 08:51:55 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON References: <1248477406-50728-1-git-send-email-agraf@suse.de> <1248477406-50728-2-git-send-email-agraf@suse.de> In-Reply-To: <1248477406-50728-2-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org Alexander Graf wrote: > MP State is implemented in the generic code, so let's move the variable > it accesses to generic code as well. > > Unbreaks PPC w/ KVM. > And breaks the build for everyone else. You change mp_state from a uint32_t to a int, but then there's: target-i386/machine.c: qemu_put_be32s(f, &env->mp_state); Which expects a uint32_t. Regards, Anthony Liguori