From: Anthony Liguori <aliguori@us.ibm.com>
To: Glauber Costa <glommer@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH 3/9] change order of kvm_init call.
Date: Mon, 27 Jul 2009 13:34:44 -0500 [thread overview]
Message-ID: <4A6DF344.6010502@us.ibm.com> (raw)
In-Reply-To: <20090727180003.GE4776@poweredge.glommer>
Glauber Costa wrote:
> we're not.
>
> The issue happens exactly when the kvm modules are not loaded, then we're failing
> to initialize kvm. However, in the patch that raised this issue, I'm moving
> KVM initialization to after this code path. And in qemu-kvm.git, kvm is
> enabled-by-default. So tcg code would think kvm is enabled and skip initialization,
> while kvm code will fail to really initialize itself later.
>
That's pure evilness.
Good argument to never fall back to TCG.
--
Regards,
Anthony Liguori
prev parent reply other threads:[~2009-07-27 18:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 23:10 [PATCH 0/9] More integration with qemu.git Glauber Costa
2009-07-20 23:10 ` [PATCH 1/9] require --enable-kvm Glauber Costa
2009-07-20 23:10 ` [PATCH 2/9] embed kvm_create_context into kvm_init Glauber Costa
2009-07-20 23:10 ` [PATCH 3/9] change order of kvm_init call Glauber Costa
2009-07-20 23:10 ` [PATCH 4/9] use qemu version of kvm initialization Glauber Costa
2009-07-20 23:10 ` [PATCH 5/9] fold second pass " Glauber Costa
2009-07-20 23:10 ` [PATCH 6/9] remove kvm_in* functions Glauber Costa
2009-07-20 23:10 ` [PATCH 7/9] reuse env stop and stopped states Glauber Costa
2009-07-20 23:10 ` [PATCH 8/9] kvm_send_ipi Glauber Costa
2009-07-20 23:10 ` [PATCH 9/9] remove kvm_abi variable Glauber Costa
2009-07-21 6:11 ` [PATCH 6/9] remove kvm_in* functions Gleb Natapov
2009-07-21 12:23 ` Glauber Costa
2009-07-21 12:18 ` Gleb Natapov
2009-07-26 18:59 ` [PATCH 3/9] change order of kvm_init call Jan Kiszka
2009-07-27 17:38 ` Glauber Costa
2009-07-27 17:49 ` Anthony Liguori
2009-07-27 18:00 ` Glauber Costa
2009-07-27 18:10 ` Jan Kiszka
2009-07-27 18:20 ` Glauber Costa
2009-07-27 18:28 ` Daniel P. Berrange
2009-07-27 18:38 ` Glauber Costa
2009-07-27 18:44 ` Daniel P. Berrange
2009-07-27 19:55 ` Glauber Costa
2009-07-27 18:34 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6DF344.6010502@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.