Re: Problem with exclusive interrupt in hostap_cs

[Larry Finger <Larry.Finger@lwfinger.net>]

Wolfram Sang wrote:
> Hi Larry,
> 
> Larry Finger wrote:
> 
>> I took a second look at the code and found that other drivers are
>> using the
>> routine prism2_interrupt() with shared interrupts, thus the patch
>> below should
>> be all that is needed.
>>
>> I trust that you will be able to build the patched driver.
>>
>> Larry
>>
>>
>> Index: wireless-testing/drivers/net/wireless/hostap/hostap_cs.c
>> ===================================================================
>> --- wireless-testing.orig/drivers/net/wireless/hostap/hostap_cs.c
>> +++ wireless-testing/drivers/net/wireless/hostap/hostap_cs.c
>> @@ -666,7 +666,8 @@ static int prism2_config(struct pcmcia_d
>>       * irq structure is initialized.
>>       */
>>      if (link->conf.Attributes & CONF_ENABLE_IRQ) {
>> -        link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
>> +        link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING |
>> +                       IRQ_HANDLE_PRESENT;
>>          link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>>          link->irq.Handler = prism2_interrupt;
>>          link->irq.Instance = dev;
> 
> Do you think this could be queued up by now? Looks okay to me...

As Dominik was missing and there was no action on the linux-pcmcia
list, I took advantage of the fact that this is a wireless device and
submitted the patch to John Linville. It is commit
e4a01604b8e5656f3a059f52b3e8f2560740c057 in the wireless-testing tree
and was sent to DaveM on July 24 for linux-next. It will be in 2.6.32.

Larry