From: Roel Kluin <roel.kluin@gmail.com>
To: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] scsi_transport_sas: Write outside array bounds
Date: Tue, 28 Jul 2009 12:20:29 +0200 [thread overview]
Message-ID: <4A6ED0ED.1090707@gmail.com> (raw)
SETUP_PORT_ATTRIBUTE increments count, making the write out of bounds (array of
size 1)
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Credits to Parfait (http://research.sun.com/projects/parfait/)
I suspect this isn't the only location where count shouldn't be incremented,
Somebody should review this function.
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
index 0895d3c..c784ae4 100644
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -1693,9 +1693,10 @@ sas_attach_transport(struct sas_function_template *ft)
count = 0;
SETUP_PORT_ATTRIBUTE(num_phys);
- i->host_attrs[count] = NULL;
count = 0;
+ i->host_attrs[count] = NULL;
+
SETUP_PHY_ATTRIBUTE(initiator_port_protocols);
SETUP_PHY_ATTRIBUTE(target_port_protocols);
SETUP_PHY_ATTRIBUTE(device_type);
next reply other threads:[~2009-07-28 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 10:20 Roel Kluin [this message]
2009-07-28 16:39 ` [PATCH] scsi_transport_sas: Write outside array bounds James Bottomley
2009-07-28 20:10 ` Jeff Garzik
2009-07-28 21:31 ` James Bottomley
2009-07-29 2:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6ED0ED.1090707@gmail.com \
--to=roel.kluin@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.