All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: Linux console tools development discussion <kbd@lists.altlinux.org>
Subject: Re: [kbd] [PATCH] Enable UNUMBERs in compose definitions
Date: Wed, 29 Jul 2009 02:41:02 +0400	[thread overview]
Message-ID: <4A6F7E7E.30207@gmail.com> (raw)
In-Reply-To: <1248436538-21478-1-git-send-email-michi@uiae.at>

24.07.2009 15:55, Michael Schutte wrote:
> As always, auto-conversion applies in case of XLATE mode (or no
> KDSKBDIACRUC support).
> 
> Signed-off-by: Michael Schutte <michi@uiae.at>
> ---
>  src/loadkeys.y |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/src/loadkeys.y b/src/loadkeys.y
> index 64cb8ee..b2ba003 100644
> --- a/src/loadkeys.y
> +++ b/src/loadkeys.y
> @@ -161,15 +161,16 @@ strline		: STRING LITERAL EQUALS STRLITERAL EOL
>  			    addfunc(kbs_buf);
>  			}
>  		;
> -compline        : COMPOSE CCHAR CCHAR TO CCHAR EOL
> +compline        : COMPOSE compsym compsym TO compsym EOL
>                          {
>  			    compose($2, $3, $5);
>  			}
> -		 | COMPOSE CCHAR CCHAR TO rvalue EOL
> -			{
> -			    compose($2, $3, $5);
> -			}
>                  ;
> +compsym		: CCHAR
> +			{ $$ = $1; }
> +		| UNUMBER
> +			{ $$ = $1 ^ 0xf000; }
> +		;
>  singleline	:	{ mod = 0; }
>  		  modifiers KEYCODE NUMBER EQUALS rvalue EOL
>  			{

You narrowed syntax. I disagree with this incompatibility.
Why you did this ?

At least, three keymaps use Literal:

$ grep -lri '^[[:space:]]*Compose.*to[[:space:]]\+[a-zA-Z][a-zA-Z_0-9]*' *
i386/qwerty/br-latin1-abnt2.map
i386/qwerty/br-latin1-us.map
i386/qwerty/et.map

-- 
Rgrds, legion



  reply	other threads:[~2009-07-28 22:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 11:55 [kbd] [PATCH] Enable UNUMBERs in compose definitions Michael Schutte
2009-07-28 22:41 ` Alexey Gladkov [this message]
2009-07-29  7:55   ` Michael Schutte
2009-07-30 11:27     ` Alexey Gladkov
2009-07-30 11:39       ` Michael Schutte
2009-07-30 12:17         ` Alexey Gladkov
2009-07-30 12:36           ` Michael Schutte
2009-07-30 15:22             ` Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6F7E7E.30207@gmail.com \
    --to=gladkov.alexey@gmail.com \
    --cc=kbd@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.