All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Dan Carpenter <error27@gmail.com>,
	corbet@lwn.net, eteo@redhat.com
Subject: Re: [PATCH] libata: add missing NULL pointer check to ata_eh_reset()
Date: Tue, 28 Jul 2009 21:10:37 -0400	[thread overview]
Message-ID: <4A6FA18D.1070808@pobox.com> (raw)
In-Reply-To: <200907261621.01893.bzolnier@gmail.com>

Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] libata: add missing NULL pointer check to ata_eh_reset()
> 
>>From Dan's list:
> 
> drivers/ata/libata-eh.c +2403 ata_eh_reset(80) warning: variable derefenced before check 'slave'
> 
> Please note that this is _not_ a real bug at the moment since ata_eh_context
> structure is embedded into ata_list structure and the code alwas checks for
> 'slave' before accessing 'sehc'.
> 
> Anyway lets add missing check and always have a valid 'sehc' pointer (which
> makes code easier to understand and prevents introducing some possible bugs
> in the future).
> 
> Reported-by: Dan Carpenter <error27@gmail.com>
> Cc: corbet@lwn.net
> Cc: eteo@redhat.com
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
>  drivers/ata/libata-eh.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to #upstream-fixes



      reply	other threads:[~2009-07-29  1:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-26 14:21 [PATCH] libata: add missing NULL pointer check to ata_eh_reset() Bartlomiej Zolnierkiewicz
2009-07-29  1:10 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6FA18D.1070808@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=bzolnier@gmail.com \
    --cc=corbet@lwn.net \
    --cc=error27@gmail.com \
    --cc=eteo@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.