From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Zdenek Kaspar <zkaspar82@gmail.com>
Subject: Re: [PATCH #upstream] libata: clear eh_info on reset completion
Date: Tue, 28 Jul 2009 21:20:06 -0400 [thread overview]
Message-ID: <4A6FA3C6.4090009@garzik.org> (raw)
In-Reply-To: <4A5FE8D9.2040702@kernel.org>
Tejun Heo wrote:
> Resets are done with port frozen but some controllers still issue
> interrupts during reset and they may end up recording error conditions
> in ehi leading to unnecessary EH retrials.
>
> This patch makes ata_eh_reset() clear ehi on reset completion. As
> reset is the most severe recovery action, there's nothing to lose by
> clearing ehi on its completion.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Zdenek Kaspar <zkaspar82@gmail.com>
> ---
> Zdenek, I moved the clearing above a bit. It should work the same but
> can you please test this one too?
>
> Jeff, after Zdenek's verification, please commit this to #upstream.
>
> Thanks.
>
> drivers/ata/libata-eh.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
applied
prev parent reply other threads:[~2009-07-29 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 2:58 [PATCH #upstream] libata: clear eh_info on reset completion Tejun Heo
2009-07-17 14:32 ` Zdenek Kaspar
2009-07-29 1:20 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6FA3C6.4090009@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
--cc=zkaspar82@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.