From: Gregory Haskins <gregory.haskins@gmail.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [regression] sched_getaffinity fails with EINVAL in 2.6.31-rc4
Date: Tue, 28 Jul 2009 23:48:53 -0400 [thread overview]
Message-ID: <4A6FC6A5.9030508@gmail.com> (raw)
In-Reply-To: <200907291118.53912.rusty@rustcorp.com.au>
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
Rusty Russell wrote:
> On Tue, 28 Jul 2009 03:42:15 am David Rientjes wrote:
>> On Mon, 27 Jul 2009, Gregory Haskins wrote:
>>
>>> I am not sure when this started, but noticed that sched_getaffinity is
>>> not working in -rc4.
>>>
>>> [pid 6254] sched_getaffinity(0, 128, 0x7f80586b1fe0) = -1 EINVAL
>>> (Invalid argument)
>>>
>>> Here is a simple program for reproduction:
>>>
>>> #include <sched.h>
>>>
>>> int main(void)
>>> {
>>> cpu_set_t mask;
>>> int ret;
>>>
>>> ret = sched_getaffinity(0, sizeof(mask), &mask);
>>> if (ret < 0)
>>> perror("getaffinity");
>>>
>>> return ret;
>>> }
>>>
>>> If I get time, I will bisect this later today.
>>>
>> It's most likely due to the cpumask changes. I don't know what cpu_set_t
>> is, but it's probably smaller than CONFIG_NR_CPUS rounded up to a multiple
>> of sizeof(long).
>
> It's simply that you finally ran this on a kernel which had
> CONFIG_NR_CPUS > 1024.
Indeed. I thought I had replied to the list that I figured that out,
but I think it might have been a trimmed list from someone elses reply.
Long story short, MAXSMP=y crept in, which set NR_CPUS=4096. Backing
this off < 1024 indeed fixes the issue.
Thanks to all who replied!
-Greg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 267 bytes --]
prev parent reply other threads:[~2009-07-29 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 17:16 [regression] sched_getaffinity fails with EINVAL in 2.6.31-rc4 Gregory Haskins
2009-07-27 17:35 ` Steven Rostedt
2009-07-27 18:12 ` David Rientjes
2009-07-29 1:48 ` Rusty Russell
2009-07-29 3:30 ` David Rientjes
2009-07-29 3:48 ` Gregory Haskins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6FC6A5.9030508@gmail.com \
--to=gregory.haskins@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.