All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	Socketcan-core@lists.berlios.de
Subject: Re: [PATCH V3] CAN: Add Flexcan CAN controller driver
Date: Wed, 29 Jul 2009 10:45:53 +0200	[thread overview]
Message-ID: <4A700C41.7030501@hartkopp.net> (raw)
In-Reply-To: <20090729082010.GZ2714@pengutronix.de>

Sascha Hauer wrote:
> And another go...
> 
> Sascha
> 
> 
> From 9f6f6fb67d57d082e056dec8121f1423c1b4fa0b Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Date: Tue, 21 Jul 2009 10:47:19 +0200
> Subject: [PATCH] CAN: Add Flexcan CAN driver
> 
> This core is found on some Freescale SoCs and also some Coldfire
> SoCs. Support for Coldfire is missing though at the moment as
> they have an older revision of the core which does not have RX FIFO
> support.
> 
> V3: integrated comments from Oliver Hartkopp
> V2: integrated comments from Wolfgang Grandegger
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Thanks Sascha!

The register access and the transition between the struct can_frame became
much clearer now.

Looks good to me.

Best regards,
Oliver

  reply	other threads:[~2009-07-29  8:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29  8:20 [PATCH V3] CAN: Add Flexcan CAN controller driver Sascha Hauer
2009-07-29  8:45 ` Oliver Hartkopp [this message]
2009-07-29  9:09 ` Wolfgang Grandegger
2009-07-30  8:37   ` Sascha Hauer
2009-07-30  8:51     ` Wolfgang Grandegger
2009-07-30  9:27       ` Sascha Hauer
2009-07-30 12:38         ` Wolfgang Grandegger
2009-07-30 20:22           ` Wolfgang Grandegger
2009-07-31 11:20             ` Sascha Hauer
2009-08-02 19:22               ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A700C41.7030501@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=Socketcan-core@lists.berlios.de \
    --cc=netdev@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.