From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: "Yang, Sheng" <sheng.yang@intel.com>,
kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: ioctl number overlapped?
Date: Wed, 29 Jul 2009 15:11:27 +0300 [thread overview]
Message-ID: <4A703C6F.7040209@redhat.com> (raw)
In-Reply-To: <20090721065146.GW5638@redhat.com>
On 07/21/2009 09:51 AM, Gleb Natapov wrote:
> On Tue, Jul 21, 2009 at 02:46:44PM +0800, Yang, Sheng wrote:
>
>> Happen to see this:
>>
>> include/linux.kvm.h
>>
>> 503 #define KVM_IRQ_LINE_STATUS _IOWR(KVMIO, 0x67, struct kvm_irq_level)
>> 504 #define KVM_REGISTER_COALESCED_MMIO \
>> 505 _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone)
>>
>> Both ioctl use 0x67, and the code has released to v2.6.30...
>>
>>
> I don't think they are really overlapping. One of them is RW another W
> (haven't checked if the structure sizeof is different).
>
>
Nevertheless we shouldn't do this.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-07-29 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 6:46 ioctl number overlapped? Yang, Sheng
2009-07-21 6:51 ` Gleb Natapov
2009-07-29 12:11 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A703C6F.7040209@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.