All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Yolkfull Chow <yzhou@redhat.com>
Cc: kvm@vger.kernel.org, autotest@test.kernel.org
Subject: Re: [PATCH] Specify the system UUID for VM
Date: Wed, 29 Jul 2009 15:18:51 +0300	[thread overview]
Message-ID: <4A703E2B.3070703@redhat.com> (raw)
In-Reply-To: <1247740006-27416-1-git-send-email-yzhou@redhat.com>

On 07/16/2009 01:26 PM, Yolkfull Chow wrote:
> Signed-off-by: Yolkfull Chow<yzhou@redhat.com>
> ---
>   client/tests/kvm/kvm_vm.py |   11 +++++++++++
>   1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
> index 503f636..895049e 100644
> --- a/client/tests/kvm/kvm_vm.py
> +++ b/client/tests/kvm/kvm_vm.py
> @@ -113,6 +113,13 @@ class VM:
>           self.qemu_path = qemu_path
>           self.image_dir = image_dir
>           self.iso_dir = iso_dir
> +
> +        if params.get("uuid"):
> +            if params.get("uuid") == "random":
> +                uuid = os.popen("cat /proc/sys/kernel/random/uuid").readline()
> +                self.uuid = uuid.strip()
>    

instead of os.popen("cat ..."), you can open the file directly:

    uuid = file('/proc/.../uuid').readline()

-- 
error compiling committee.c: too many arguments to function


  parent reply	other threads:[~2009-07-29 12:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 10:26 [PATCH] Specify the system UUID for VM Yolkfull Chow
2009-07-16 11:54 ` Yolkfull Chow
2009-07-17 15:17 ` [PATCH] Add UUID option into kvm command line Yolkfull Chow
2009-07-20 12:43   ` Lucas Meneghel Rodrigues
2009-07-29 12:18 ` Avi Kivity [this message]
2009-07-29 12:36   ` [PATCH] Specify the system UUID for VM Lucas Meneghel Rodrigues
2009-07-29 12:46     ` Lucas Meneghel Rodrigues
2009-07-29 12:46     ` [Autotest] " Michael Goldish
2009-07-29 12:48       ` Lucas Meneghel Rodrigues
2009-07-29 13:03       ` Avi Kivity
2009-07-29 13:06   ` Yolkfull Chow
2009-07-29 13:25     ` Yolkfull Chow
  -- strict thread matches above, loose matches on Subject: below --
2009-07-16 11:58 Yolkfull Chow
     [not found] <1454873599.553791247747852804.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-07-16 12:49 ` Michael Goldish
2009-07-17  8:55   ` Yolkfull Chow
     [not found] <1260173646.620381247825145929.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-07-17 10:11 ` Michael Goldish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A703E2B.3070703@redhat.com \
    --to=avi@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=yzhou@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.