[Qemu-devel] Re: [PATCH] add --accel option

[Kevin Wolf <kwolf@redhat.com>]

Juan Quintela schrieb:
> Glauber Costa <glommer@redhat.com> wrote:
>> On Wed, Jul 29, 2009 at 10:16:28AM +0200, Kevin Wolf wrote:
>>> Glauber Costa schrieb:
>>>> Since libvirt dudes seem to prefer it, add a --accel option. For now,
>>>> it only does the same as --enable-kvm, but it can easily be extended
>>>> in the future. It also accepts "none" and "kqemu" options.
>>> The documentation should include which values are valid for the option.
>>> Guessing that the syntax is -accel kvm is probably possible, but for
>>> -accel kqemu,mode=kernel it's definitely hard.
>> right now kqemu needs an extra argument.
>>
>> But very soon kvm will need it too. Like for example controlling knobs
>> like kvm-irqchip and kvm-pit. So maybe we want a standard way of passing
>> arguments for all accels?
>>
>> How about --accel foo,args=bar,bar,bar with the args part being optional ?
>>
>> An exampel would be --accel kvm,args=userpit,userirqchip (assuming we want the
>> default to be in the kernel)
>>
>> Otherwise we're stuck with an evergrowing combination to support
> 
> No, pleaseeee
> "," shouldn't have two meanings in the same command line
> 
> --accel kvm,userpit,userirqchip
> 
> is ok
> 
> --accell kvm,userpit=on,userirqchip=off
> 
> also ok

QemuOpts supports both of these (and none of the versions below).

Kevin


> 
> --accell kvm,args=userpit,userirqchip
> 
> parses as
>    args=userpit
>    userirqchip
> or
>    args=userpit,userirqchip
> 
> IMHO, having lists inside lists is just insane, and if you want it, do
> it marking the list properly:
> 
> --accell kvm,args=[userpit,userirqchip]
> 
> or any other opening/closing pair.
> 
> Later, Juan.