From: Warren Togami <wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: initramfs <initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Broken substitution
Date: Wed, 29 Jul 2009 17:13:11 -0400 [thread overview]
Message-ID: <4A70BB67.7030803@redhat.com> (raw)
Upstream dhclient writes out \032 instead of a space if multiple search
domains are specified in dhcpd.conf. It has been this way for years.
Debian and Fedora have worked around this by doing the below bash
substitution. Upstream has rejected fixing this in dhclient for
different reasons.
The substitution below works on bash but not dash.
Dillow suggested this method that will work with bash and dash.
Unfortunately I now noticed that this seems to remove the space between
search domain entries.
Any suggestions of how we can fix this?
Warren Togami
wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Author: David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org> 2009-07-23 23:16:31
Committer: Warren Togami <wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-23 23:16:31
Parent: ef380e9de85db798e4994a981ef00a2857af9c79 (Turns out this is
really a misconfigured DHCP server, apply the same workaround as Debian
and upstream dhclient-script.)
Child: b03edf372f8eee9097311c64cdee431e45049dc0
(40network/parse-bridge: add bridge to $initrdargs)
Branches: master, remotes/origin/master
Follows: 0.6
Precedes:
dash compatible substitution
--------------------- modules.d/40network/dhclient-script
---------------------
index 142095d..1ef239a 100755
@@ -7,7 +7,7 @@ setup_interface() {
bcast=$new_broadcast_address
gw=${new_routers%%,*}
domain=$new_domain_name
- search="${new_domain_search//\\032/ }"
+ search=$(printf "$new_domain_search")
namesrv=$new_domain_name_servers
hostname=$new_host_name
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-07-29 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 21:13 Warren Togami [this message]
[not found] ` <4A70BB67.7030803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-07-29 21:37 ` Broken substitution David Dillow
[not found] ` <1248903464.19166.43.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
2009-07-29 21:39 ` Warren Togami
[not found] ` <4A70C190.6050902-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-07-29 23:00 ` David Dillow
[not found] ` <1248908439.8777.9.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2009-07-30 1:57 ` David Dillow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A70BB67.7030803@redhat.com \
--to=wtogami-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.