[Qemu-devel] Re: [PATCH 3/7] If we built a rom, install it. Otherwise, use shipped copy.

[Anthony Liguori <aliguori@us.ibm.com>]

Juan Quintela wrote:
> Anthony Liguori <aliguori@us.ibm.com> wrote:
>   
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>     
>
> Hi
>
> If we are shuffling directories anyways, can we:
>
>   
>> +        # FIXME: this is terrible
>> +	for rom in multiboot; do \
>> +	  case $$rom in \
>> +	    multiboot) srcbin=multiboot.bin ;; \
>> +	  esac; \
>> +	  if test -z "$$dstbin" ; then \
>> +	    dstbin=$$srcbin ; \
>> +	  fi; \
>> +	  if test -e pc-bios/$$rom/$$srcbin ; then \
>>     
>
>   
>> +	    $(INSTALL_DATA) pc-bios/$$rom/$$srcbin "$(DESTDIR)$(datadir)/$$dstbin"; \
>> +	  else \
>> +	    $(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$dstbin "$(DESTDIR)$(datadir)"; \
>>     
>                                                 ^^^^^^^^
> move this one to something like roms_precompiled/ or similar?
>
> At this point we are going to have:
>
> source bios in $TOP_LEVEL/roms/
> prebuilt bios in $TOP_LEVEL/pc-bios/
> compiled bios in $TOP_LEVEL/<name_rom_rom>/<name_rom>
>   

pc-bios should go away as it's a misnomer.  Long term, I think we want 
something like:

$TOP_LEVEL/roms
$TOP_LEVEL/roms/shipped
$TOP_LEVEL/roms/src/$ROMNAME
$TOP_LEVEL/roms/build/$BUILDNAME

and pc-bios goes away.  But there are greater ramifications to this 
because -L /path/to/git/pc-bios no longer works.  I think we probably 
need to think through a reorganization of <prefix>/share/qemu or make -L 
smarter wrt the build system.

Either way, I see this sort of reorganization a follow on to this 
series.  I want to get this series in so we can start pulling in new 
roms like seabios.

-- 
Regards,

Anthony Liguori