From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] chunkd: configure now detects location of cld program Date: Wed, 29 Jul 2009 21:43:44 -0400 Message-ID: <4A70FAD0.3000107@garzik.org> References: <4A70BE6B.7070906@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A70BE6B.7070906@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Matthew Farrellee Cc: hail-devel@vger.kernel.org Matthew Farrellee wrote: > make check attempts to start cld, but cannot find it if it is not > already in PATH. This patch uses CLDC_PREFIX, possibly from > pkg-config, to detect the location of cld with configure. > > Signed-off-by: Matthew Farrellee > --- > configure.ac | 19 +++++++++++++++++++ > test/Makefile.am | 1 + > test/start-daemon | 20 +------------------- > test/start-daemon.real.in | 20 ++++++++++++++++++++ > 4 files changed, 41 insertions(+), 19 deletions(-) > create mode 100644 test/start-daemon.real.in oh, FYI: this missed updating test/.gitignore to tell git to ignore the generated file. Typically you want to run "git status" after builds and such, to make sure that git is aware of the status of all files (in repo, or ignored). Running "git status" is a good habit to get into. At least for me, I have sent out patches that accidentally omit newly added files, because I forgot to run "git status". Thanks! Jeff