From: Gerd Hoffmann <kraxel@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] Remove the virtio-{blk, console}-pci-0-10 device types
Date: Thu, 30 Jul 2009 14:22:16 +0200 [thread overview]
Message-ID: <4A719078.6020003@redhat.com> (raw)
In-Reply-To: <1248949753-13269-3-git-send-email-markmc@redhat.com>
On 07/30/09 12:29, Mark McLoughlin wrote:
> These are now unused.
>
> However, perhaps the idea is that when we add -device, they will be
> useful? In that case, we should add virtio-net-pci-0-10 too.
With -device you can switch devices into compat mode by simply setting
the attribute. Doesn't work (yet) because you can't create functional
virtio console+block devices via -device right now. I'll plan to have
that fixed at least for virtio blk soon though. For virtio-net this can
be done today (-net nic,model=virtio,vectors=0 turns off msi).
So IMHO there is no need in keeping the device types and the patch
should be applied.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
prev parent reply other threads:[~2009-07-30 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 10:29 [Qemu-devel] [PATCH 0/2] Compat cleanups Mark McLoughlin
2009-07-30 10:29 ` [Qemu-devel] [PATCH 1/2] Remove the pc-0-10 machine type Mark McLoughlin
2009-07-30 12:13 ` Gerd Hoffmann
2009-07-30 10:29 ` [Qemu-devel] [PATCH 2/2] Remove the virtio-{blk, console}-pci-0-10 device types Mark McLoughlin
2009-07-30 12:22 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A719078.6020003@redhat.com \
--to=kraxel@redhat.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.