From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: remove chown from makefiles too? Date: Thu, 30 Jul 2009 09:59:09 -0500 Message-ID: <4A71B53D.7070205@redhat.com> Reply-To: NILFS Users mailing list Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: users-bounces-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org Errors-To: users-bounces-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org To: NILFS Users mailing list Hi, after the setuid bits got removed from the make install process, this sort of thing is still left in several Makefiles: install-exec-hook: list='$(sbin_PROGRAMS)'; \ for p in $$list; do \ chown root $(DESTDIR)$(sbindir)/$$p$(EXEEXT); \ done But this fails for a normal user installing into a chroot, as an rpmbuild by a non-root user might do. I don't think there's any reason for the chown; can this just be removed? Thanks, -Eric