All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "Jiang, Yunhong" <yunhong.jiang@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: One question on xen_cpuid in pv guest
Date: Thu, 30 Jul 2009 10:06:36 -0700	[thread overview]
Message-ID: <4A71D31C.7020307@goop.org> (raw)
In-Reply-To: <E2263E4A5B2284449EEBD0AAB751098402CDF659F0@PDSMSX501.ccr.corp.intel.com>

On 07/29/09 22:44, Jiang, Yunhong wrote:
> Jeremy, thanks for clarification, but I still not sure about following code in pv_ops dom0. Since the Local APIC is owned by Xen totally, why is it not "outright forbidden for the guest"?
>
>
>     if (!xen_initial_domain())
>         cpuid_leaf1_edx_mask &=
>             ~((1 << X86_FEATURE_APIC) |  /* disable local APIC */
>               (1 << X86_FEATURE_ACPI));  /* disable ACPI */
>   

Some of the approaches to implementing dom0 pretend the local APIC
exists in order to fool various code-paths into doing the right thing
(for example, getting the kernel to parse all the MADT tables, which it
won't do if there's no local APIC).

Historically I think the policy has been for Xen to explicitly blacklist
features which turn out to be problematic when they become problematic,
rather than whitelist features known to be safe.

    J

      reply	other threads:[~2009-07-30 17:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29  3:19 One question on xen_cpuid in pv guest Jiang, Yunhong
2009-07-29 16:54 ` Jeremy Fitzhardinge
2009-07-30  5:44   ` Jiang, Yunhong
2009-07-30 17:06     ` Jeremy Fitzhardinge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A71D31C.7020307@goop.org \
    --to=jeremy@goop.org \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.