From: Graeme Gregory <dp@xora.org.uk>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] remove duplicated code from linux.inc
Date: Fri, 31 Jul 2009 08:12:03 +0100 [thread overview]
Message-ID: <4A729943.4060200@xora.org.uk> (raw)
In-Reply-To: <4A7255D3.9020703@gmail.com>
Graham Gower wrote:
> Graeme Gregory wrote:
>> Why dont you prepend it to the current uImage creation code running
>> only conditionally on UBOOT_ENTRYSYMBOL being set? As its in the same
>> bit of shell code your resetting of UBOOT_ENTRYPOINT will take
>> precedence! Also means other machines can use it.
>
> Once I realised that ${FOO} is replaced before the shell function is run,
> while $FOO is not, things made a lot more sense.
>
> Allow a dynamic entry point via UBOOT_ENTRYSYMBOL and remove redundant
> uboot-mkimage code in kernel.bbclass.
>
Looks good to me, do you fancy moving that do_compile_append into
kernel.bbclass? You can then have the added kudos of fixing OE core
files :-)
Graeme
next prev parent reply other threads:[~2009-07-31 7:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 4:30 [PATCH] remove duplicated code from linux.inc Graham Gower
2009-07-29 7:34 ` Koen Kooi
2009-07-29 8:36 ` Marcin Juszkiewicz
2009-07-29 8:38 ` Graeme Gregory
2009-07-29 9:31 ` Marcin Juszkiewicz
2009-07-30 5:11 ` Graham Gower
2009-07-30 5:33 ` Tom Rini
2009-07-30 5:49 ` Graham Gower
2009-07-30 8:59 ` Graeme Gregory
2009-07-31 2:24 ` Graham Gower
2009-07-31 7:12 ` Graeme Gregory [this message]
2009-07-31 7:40 ` Graham Gower
2009-07-31 8:55 ` Graeme Gregory
2009-07-31 9:59 ` Koen Kooi
2009-07-31 11:33 ` Graeme Gregory
2009-07-31 12:35 ` Graham Gower
2009-07-31 13:24 ` Marcin Juszkiewicz
2009-08-01 9:45 ` Graham Gower
2009-08-03 6:54 ` Marcin Juszkiewicz
2009-07-31 17:45 ` Koen Kooi
2009-07-31 7:50 ` Andrea Adami
2009-07-31 9:03 ` Graham Gower
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A729943.4060200@xora.org.uk \
--to=dp@xora.org.uk \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.