From: Richard Henderson <rth@twiddle.net>
To: Tim Abbott <tabbott@ksplice.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Anders Kaseorg <andersk@ksplice.com>,
Nelson Elhage <nelhage@ksplice.com>,
linux-alpha@vger.kernel.org
Subject: Re: [PATCH 1/2] alpha: use .data.init_task instead of .data.init_thread.
Date: Fri, 31 Jul 2009 14:23:15 -0700 [thread overview]
Message-ID: <4A7360C3.2060507@twiddle.net> (raw)
In-Reply-To: <1249073786-29788-1-git-send-email-tabbott@ksplice.com>
On 07/31/2009 01:56 PM, Tim Abbott wrote:
> - /* Note 2 page alignment above. */
> - .data.init_thread : {
> - *(.data.init_thread)
> - }
NACK.
You can change the section name, sure, but you cannot remove the 2 page
alignment that we had via the alignment at the end of the init sections.
You'll break current_thread_info which is always computed as
(kernel-stack-pointer & -(2*PAGE_SIZE)).
Similarly it is *not* a bug that the page_aligned sections were before
data, because we already knew we had 2 page alignment from the end of
init + 2 pages of init_thread.
r~
next prev parent reply other threads:[~2009-07-31 21:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 20:56 [PATCH 1/2] alpha: use .data.init_task instead of .data.init_thread Tim Abbott
2009-07-31 20:56 ` [PATCH 2/2] alpha: Clean up linker script using new linker script macros Tim Abbott
2009-07-31 21:23 ` Richard Henderson [this message]
2009-07-31 21:38 ` [PATCH 1/2] alpha: use .data.init_task instead of .data.init_thread Richard Henderson
2009-07-31 23:44 ` Tim Abbott
2009-07-31 22:02 ` Tim Abbott
2009-07-31 23:30 ` Richard Henderson
2009-07-31 23:56 ` Tim Abbott
2009-08-02 16:25 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7360C3.2060507@twiddle.net \
--to=rth@twiddle.net \
--cc=andersk@ksplice.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nelhage@ksplice.com \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.