All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	linux acpi <linux-acpi@vger.kernel.org>,
	acpi4asus-user@lists.sourceforge.net
Subject: Re: Illuminated keyboard on ASUS U50VG laptop, backlight or led ?
Date: Sat, 01 Aug 2009 12:19:02 +0100	[thread overview]
Message-ID: <4A7424A6.5080703@tuffmail.co.uk> (raw)
In-Reply-To: <71cd59b00908010340m2b48d581n4c8cb470921e4652@mail.gmail.com>

Corentin Chary wrote:
> On Tue, Jul 28, 2009 at 10:04 PM, Matthew Garrett<mjg59@srcf.ucam.org> wrote:
>   
>> On Tue, Jul 28, 2009 at 09:51:09PM +0200, Corentin Chary wrote:
>>
>>     
>>> No answers.
>>> I think I'll implement that as a backlight, because it is a backlight
>>> even if it's not for a screen.
>>>       
>> I believe the SMC driver for the Apples does it via LED, so it might
>> make sense to be consistent with that.
>>
>> --
>> Matthew Garrett | mjg59@srcf.ucam.org
>>
>>     
>
> So it will be a led.
>   

I think you should also match the LED name used by the apple driver.  As
far as I know it's the only sensible way for userspace to identify the
LED.  The SMC driver uses "smc::kbd_backlight",  so something like
"eeepc::kbd_backlight".

> There is another problem, Fn+F3/F4 generate ACPI events
>
> Fn+F3 : hotkey ATKD 000000c5 00000000
> Fn+F4 : hotkey ATKD 000000c4 00000000
>
> Fn+F3: decreases keyboard brightness
> Fn+F4: increases keyboard brightness
>
> Should we handle these events with acpi scripts or directly in the driver ?
> IMHO it can be done directly in the driver, like LCD On/Off keys.
>   

Here's my opinion based on no experience and 10 minutes with google :-).

Userspace should take charge of changing the brightness.  It would be
good to generate input events (KEY_KBDILLUMUP etc) as well though.

Hopefully hald-addon-generic-kbd-backlight already responds to
KEY_KBDILLUM*.  If so, then one could use Hal along with an FDI file
like the apple one
(<http://lists.freedesktop.org/archives/hal/2008-October/012360.html>). 
That's close to what we should ultimately be aiming for, except for the
specific match on "smc::kbd_backlight".  It would be great to just have
one rule matching on *::kbd_backlight.

Alan

  reply	other threads:[~2009-08-01 11:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24  7:34 Illuminated keyboard on ASUS U50VG laptop, backlight or led ? Corentin Chary
2009-07-28 19:51 ` Corentin Chary
2009-07-28 20:04   ` Matthew Garrett
2009-08-01 10:40     ` Corentin Chary
2009-08-01 11:19       ` Alan Jenkins [this message]
2009-08-01 12:40         ` Corentin Chary
2009-08-01 13:21           ` Danny Kukawka
2009-08-01 15:50             ` Corentin Chary
2009-08-01 16:30               ` Alan Jenkins
2009-08-01 17:21                 ` Danny Kukawka
2009-08-01 19:43                   ` Alan Jenkins
2009-08-01 19:47                     ` Alan Jenkins
2009-08-02  7:20                     ` Corentin Chary
2009-08-06 10:07                       ` Corentin Chary
2009-08-06 10:48                         ` Danny Kukawka
2009-08-06 11:59                           ` Corentin Chary
2009-08-06 16:20                             ` Danny Kukawka
2009-08-06 17:00                               ` Corentin Chary
2009-12-07  7:51                               ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7424A6.5080703@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.