All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Albert <jal2@gmx.de>
To: Bob Copeland <me@bobcopeland.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: ath5k: monitor mode needs channel change
Date: Sun, 02 Aug 2009 00:14:33 +0200	[thread overview]
Message-ID: <4A74BE49.4090909@gmx.de> (raw)
In-Reply-To: <b6c5339f0907311140o7e92a74eqf3ad095ac8412281@mail.gmail.com>

On 07/31/2009 08:40 PM, Bob Copeland wrote:

> Hmm, well, probably a ath5k_reset() in add_interface would do the
> trick.  Maybe there's some wrong assumption about when
> configure_filter() is called.

Adding ath5k_reset() to the end of ath5k_add_interface didn't help.

Seems like in the case of

ifconfig wlan0 down
iwconfig wlan0 mode monitor channel 1
ifconfig wlan0 up

ath5k_chan_set() is called by ath5k_config() with sc->curchan == chan
and it doesn't call ath5k_reset() - which I guess is needed
to activate the new hw rx_filter.
ath5k_config() gets parameter changed == 0xffffffff,
i.e. CONF_CHANGE_CHANNEL is flagged.

With the following

iwconfig wlan0 channel 2

ath_chan_set() gets called with
sc->curchan->center_freq != chan->center_freq and
ath5k_reset() is invoked.

Patch follows.

Regards,
Joerg.

      reply	other threads:[~2009-08-01 22:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30 21:31 ath5k: monitor mode needs channel change Joerg Albert
2009-07-30 22:05 ` Bob Copeland
2009-07-31 18:34   ` Joerg Albert
2009-07-31 18:40     ` Bob Copeland
2009-08-01 22:14       ` Joerg Albert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A74BE49.4090909@gmx.de \
    --to=jal2@gmx.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.