All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Albert <jal2@gmx.de>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: ar9170usb crashes during iwconfig for ad-hoc mode
Date: Mon, 03 Aug 2009 00:28:08 +0200	[thread overview]
Message-ID: <4A7612F8.80802@gmx.de> (raw)
In-Reply-To: <4A759341.1090006@gmx.de>

On 08/02/2009 03:23 PM, Joerg Albert wrote:
> After
>     ifconfig wlan1 down
>     iwconfig wlan1 mode managed essid huhu
>     ifconfig wlan1 up
>     ifconfig wlan1 down
>     iwconfig wlan1 mode ad-hoc essid huhu_a channel 1
> 
> ar9170 crashes (see below for the syslog).
> 
> It seems like ar9170_op_bss_info_changed() is called with ar->vif == NULL
> (i.e. ((struct ar9170 *)hw->priv)->vif == NULL), while parameter vif != 
> NULL and
> changed & (BSS_CHANGED_BEACON | BSS_CHANGED_BEACON_ENABLED) is non-zero.
> ar->vif is passed unchecked to ieee80211_beacon_get().
> 
> Is this something ar9170 is supposed to handle or a bug in 
> cfg80211/mac80211?
> Is a driver's *bss_info_changed proc called while the netdev is closed?

It looks like ar->vif is set to NULL by ar9170_remove_interface() and the one call
of ar9170_op_bss_info_changed() when ad-hoc is configured has changed==BSS_CHANGED_BEACON_ENABLED
with bss_info->enable_beacon == 0.
So it's a bug in the ar9170. I'll try to post a patch.

  reply	other threads:[~2009-08-02 22:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-02 13:23 ar9170usb crashes during iwconfig for ad-hoc mode Joerg Albert
2009-08-02 22:28 ` Joerg Albert [this message]
2009-08-03  8:44   ` Johannes Berg
2009-08-03  8:47     ` Johannes Berg
2009-08-03 12:36       ` Joerg Albert
2009-08-03 13:09         ` Christian Lamparter
2009-08-03 20:46           ` Joerg Albert
2009-08-03 14:25         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7612F8.80802@gmx.de \
    --to=jal2@gmx.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.