Re: [PATCH] kvm: Drop obsolete cpu_get/put in make_all_cpus_request

[Avi Kivity <avi@redhat.com>]

On 07/21/2009 03:00 AM, Marcelo Tosatti wrote:
> Jan,
>
> This was suggested but we thought it might be safer to keep the
> get_cpu/put_cpu pair in case -rt kernels require it (which might be
> bullshit, but nobody verified).
>
>    

Thinking about it, it is bullshit:

>>
>> -	me = get_cpu();
>>   	spin_lock(&kvm->requests_lock);
>> +	me = smp_processor_id();
>>      

The -rt kernel cannot substitute a mutex for the spinlock here, since we 
are pinned to a single cpu.  It will have to use a raw spinlock here.

However, the 'me' variable is completely spurious.  It only affects the 
statistics gathering, I think we can safely drop it.

-- 
error compiling committee.c: too many arguments to function