All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Normal command line behavior?
Date: Mon, 03 Aug 2009 15:35:56 -0400	[thread overview]
Message-ID: <4A773C1C.7080109@ge.com> (raw)
In-Reply-To: <17434f2e0908031219h7d630d9sc019cf726ce9c1c8@mail.gmail.com>

J.C. Wren wrote:
> I notice that when I hit return at a U-Boot > prompt, it executes the last
> command again.  CONFIG_SYS_HUSH_PARSER is defined, from U-Boot
> 2009.08-rc1-00030-g56bdfa9-dirty.
> 
> It this is expected, it seems like a *really* bad idea.  It's cost me having
> to reload 6M images at 115200 twice now.
> 
> --jc

Hi JC,

It is a configuration/design decision: see include/command.h line 46ff, 
struct cmd_tbl_s, field "repeatable".  This is configured via the 
U_BOOT_CMD macro.

<http://git.denx.de/?p=u-boot.git;a=blob;f=include/command.h;h=55caa6eaf888cdb916d3937a5054ad862ec0e0ab;hb=HEAD#l46>

Sometimes it is nice (e.g. sequencing through memory dumps), sometimes 
it bites (you found one of those!).  IMHO, it is enabled in places where 
it would be better to rely on command line recall rather than the repeat 
function.

I think the repeat functionality predated the command line recall 
functionality, so it use to be more desirable to repeat the command 
because there wasn't an alternative way to repeat the command.

Best regards,
gvb

  reply	other threads:[~2009-08-03 19:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03 19:19 [U-Boot] Normal command line behavior? J.C. Wren
2009-08-03 19:35 ` Jerry Van Baren [this message]
2009-08-03 21:58   ` Wolfgang Denk
2009-08-04 16:07     ` J.C. Wren
2009-08-04 19:48       ` Scott Wood
2009-08-04 20:05         ` J.C. Wren
2009-08-04 20:42           ` Wolfgang Denk
2009-08-13  5:06       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A773C1C.7080109@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.