From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gui Jianfeng Subject: Re: [PATCH] io-controller: implement per group request allocation limitation Date: Tue, 04 Aug 2009 14:41:13 +0800 Message-ID: <4A77D809.1040906@cn.fujitsu.com> References: <1246564917-19603-1-git-send-email-vgoyal@redhat.com> <4A569FC5.7090801@cn.fujitsu.com> <4A7796D2.4030104@ds.jp.nec.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A7796D2.4030104@ds.jp.nec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Munehiro Ikeda Cc: dhaval@linux.vnet.ibm.com, snitzer@redhat.com, peterz@infradead.org, dm-devel@redhat.com, dpshah@google.com, jens.axboe@oracle.com, agk@redhat.com, balbir@linux.vnet.ibm.com, paolo.valente@unimore.it, fernando@oss.ntt.co.jp, mikew@google.com, jmoyer@redhat.com, nauman@google.com, Vivek Goyal , righi.andrea@gmail.com, lizf@cn.fujitsu.com, fchecconi@gmail.com, akpm@linux-foundation.org, jbaron@redhat.com, linux-kernel@vger.kernel.org, s-uchida@ap.jp.nec.com, containers@lists.linux-foundation.org List-Id: dm-devel.ids Munehiro Ikeda wrote: > Gui Jianfeng wrote, on 07/09/2009 09:56 PM: >> Hi Vivek, >> >> This patch exports a cgroup based per group request limits interface. >> and removes the global one. Now we can use this interface to perform >> different request allocation limitation for different groups. >> >> Signed-off-by: Gui Jianfeng >> --- > (snip) > > Hi Jianfeng, > > If this helps. > > If calling elv_io_group_congestion_threshold() before > setting iog->iocg_id, iocg->nr_group_requests cannot be > referred. As a result of it, iog->nr_congestion_on is > always misculculated as 0. > This patch moves the calling of > elv_io_group_congestion_threshold() after setting > iog->iocg_id. > > Signed-off-by: Munehiro "Muuhh" Ikeda That's true, thanks. -- Regards Gui Jianfeng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932467AbZHDGmp (ORCPT ); Tue, 4 Aug 2009 02:42:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932248AbZHDGmo (ORCPT ); Tue, 4 Aug 2009 02:42:44 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:56936 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932239AbZHDGmo (ORCPT ); Tue, 4 Aug 2009 02:42:44 -0400 Message-ID: <4A77D809.1040906@cn.fujitsu.com> Date: Tue, 04 Aug 2009 14:41:13 +0800 From: Gui Jianfeng User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Munehiro Ikeda CC: Vivek Goyal , linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, dm-devel@redhat.com, jens.axboe@oracle.com, nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, ryov@valinux.co.jp, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com, righi.andrea@gmail.com, jbaron@redhat.com, agk@redhat.com, snitzer@redhat.com, akpm@linux-foundation.org, peterz@infradead.org Subject: Re: [PATCH] io-controller: implement per group request allocation limitation References: <1246564917-19603-1-git-send-email-vgoyal@redhat.com> <4A569FC5.7090801@cn.fujitsu.com> <4A7796D2.4030104@ds.jp.nec.com> In-Reply-To: <4A7796D2.4030104@ds.jp.nec.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Munehiro Ikeda wrote: > Gui Jianfeng wrote, on 07/09/2009 09:56 PM: >> Hi Vivek, >> >> This patch exports a cgroup based per group request limits interface. >> and removes the global one. Now we can use this interface to perform >> different request allocation limitation for different groups. >> >> Signed-off-by: Gui Jianfeng >> --- > (snip) > > Hi Jianfeng, > > If this helps. > > If calling elv_io_group_congestion_threshold() before > setting iog->iocg_id, iocg->nr_group_requests cannot be > referred. As a result of it, iog->nr_congestion_on is > always misculculated as 0. > This patch moves the calling of > elv_io_group_congestion_threshold() after setting > iog->iocg_id. > > Signed-off-by: Munehiro "Muuhh" Ikeda That's true, thanks. -- Regards Gui Jianfeng