From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH] c/r: Fix no-dot-config-targets pattern in linux/Makefile Date: Tue, 04 Aug 2009 04:20:45 -0400 Message-ID: <4A77EF5D.7070501@librato.com> References: <1249328610.7138.23.camel@Maple> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1249328610.7138.23.camel@Maple> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: John Dykstra Cc: Dan Smith , Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org John Dykstra wrote: > Oren, I'm not sure who you're accepting patches from, but... I accept any good patch :) (pushed to ckpt-v17-dev) Oren. > > -- > Kernel builds that specify targets in the checkpoint/ directory will > fail or be incorrect because the autoconfig files were not included. > One way to reproduce the problem is: > > make checkpoint/sys.s > > The problem is that this pattern in linux/Makefile matches files in the > checkpoint/ directory: > > no-dot-config-targets := clean mrproper distclean \ > cscope TAGS tags help %docs check% \ > include/linux/version.h headers_% \ > kernelrelease kernelversion > > Make the pattern more exact, per the current set of linux build targets. > > Signed-off-by: John Dykstra > --- > Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index cf631d7..17445a6 100644 > --- a/Makefile > +++ b/Makefile > @@ -400,7 +400,7 @@ endif > # of make so .config is not included in this case either (for *config). > > no-dot-config-targets := clean mrproper distclean \ > - cscope TAGS tags help %docs check% \ > + cscope TAGS tags help %docs checkstack \ > include/linux/version.h headers_% \ > kernelrelease kernelversion >