From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Luk=E1=9A_Doktor?= <ldoktor@redhat.com>
Subject: Re: [KVM-AUTOTEST PATCH] KVM test: Add hugepage variant
Date: Tue, 04 Aug 2009 15:00:07 +0200
Message-ID: <4A7830D7.90505@redhat.com>
References: <1248838829-7804-1-git-send-email-lmr@redhat.com> <20090729144104.GA21912@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
To: KVM list <kvm@vger.kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:36694 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755490AbZHDNAI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 4 Aug 2009 09:00:08 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n74D09dZ013369
	for <kvm@vger.kernel.org>; Tue, 4 Aug 2009 09:00:09 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n74D08CA016776
	for <kvm@vger.kernel.org>; Tue, 4 Aug 2009 09:00:09 -0400
Received: from [10.34.33.254] (dhcp-lab-254.englab.brq.redhat.com [10.34.33.254])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n74D07ki030110
	for <kvm@vger.kernel.org>; Tue, 4 Aug 2009 09:00:08 -0400
In-Reply-To: <20090729144104.GA21912@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hello Ryan,

see below...

Dne 29.7.2009 16:41, Ryan Harper napsal(a):
> * Lucas Meneghel Rodrigues<lmr@redhat.com>  [2009-07-28 22:40]:
>> This patch adds a small setup script to set up huge memory
>> pages during the kvm tests execution. Also, added hugepage setup to =
the
>> fc8_quick sample.
>>
>> Signed-off-by: Luk=E1?? Doktor<ldoktor@redhat.com>
>> Signed-off-by: Lucas Meneghel Rodrigues<lmr@redhat.com>
>
> Looks good.  one nit below.
>
> Signed-off-by: Ryan Harper<ryanh@us.ibm.com>
>
>> ---
>> +
>> +    def get_target_hugepages(self):
>> +        """
>> +        Calculate the target number of hugepages for testing purpos=
es.
>> +        """
>> +        if self.vms<  self.max_vms:
>> +            self.vms =3D self.max_vms
>> +        vmsm =3D (self.vms * self.mem) + (self.vms * 64)
>
> Nit: Maybe a comment about the fudge factor being added in?

It's qemu-kvm overhead. Should I change the patch or is this explanatio=
n=20
sufficient?

Thanks for the feedback,
bye, Luk=E1=9A