All of lore.kernel.org
 help / color / mirror / Atom feed
From: Graham Gower <graham.gower@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [PATCH] fix portmap on mips, remove old slugos workaround
Date: Wed, 05 Aug 2009 15:52:17 +0930	[thread overview]
Message-ID: <4A792519.20506@gmail.com> (raw)

Portmap built for mipsel with gcc-4.3.3 segfaults instantly, fails to build
with gcc-4.4 and provides the following:

| /home/grg/oe/tmp/cross/mipsel/lib/gcc/mipsel-angstrom-linux/4.4.1/../../../../mipsel-angstrom-linux/bin/ld: portmap.o: relocation R_MIPS_HI16 against `__gnu_local_gp' can not be used when making a shared object; recompile with -fPIC

The CFLAGS in portmap's Makefile contains -fpie, but is ignored. The
CFLAGS I've added below are constructed from portmap's Makefile. When
built with gcc-4.3.3 the resultant binary no longer segfaults.

RE: Remove this patch when SlugOS upgrades to binutils 1.18
It looks like this is now the case, so I've removed the slugos workaround.

-Graham

diff --git a/recipes/portmap/portmap-6.0/no-pie.patch b/recipes/portmap/portmap-6.0/no-pie.patch
deleted file mode 100644
index 4d7e2da..0000000
--- a/recipes/portmap/portmap-6.0/no-pie.patch
+++ /dev/null
@@ -1,14 +0,0 @@
---- portmap_6.0/Makefile.orig	2007-11-21 00:35:52.000000000 -0600
-+++ portmap_6.0/Makefile	2007-11-21 00:37:23.000000000 -0600
-@@ -125,9 +125,9 @@
- all:	portmap pmap_dump pmap_set portmap.man
- 
- CPPFLAGS += $(HOSTS_ACCESS)
--portmap: CFLAGS   += -fpie
-+#portmap: CFLAGS   += -fpie
- portmap: LDLIBS   += $(WRAP_LIB)
--portmap: LDFLAGS  += -pie
-+#portmap: LDFLAGS  += -pie
- portmap: portmap.o pmap_check.o from_local.o
- 
- from_local: CPPFLAGS += -DTEST
diff --git a/recipes/portmap/portmap_6.0.bb b/recipes/portmap/portmap_6.0.bb
index cb94a48..501aa5d 100644
--- a/recipes/portmap/portmap_6.0.bb
+++ b/recipes/portmap/portmap_6.0.bb
@@ -1,6 +1,6 @@
 require portmap.inc
 
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "http://www.sourcefiles.org/Networking/Tools/Miscellanenous/portmap-6.0.tgz \
            file://destdir-no-strip.patch;patch=1 \
@@ -8,12 +8,10 @@ SRC_URI = "http://www.sourcefiles.org/Networking/Tools/Miscellanenous/portmap-6.
            file://no-libwrap.patch;patch=1;pnum=0 \
            file://portmap.init "
 
-# Remove this patch when SlugOS upgrades to binutils 1.18
-SRC_URI_append_slugos = " file://no-pie.patch;patch=1 "
-
 S = "${WORKDIR}/${PN}_${PV}/"
 
 CPPFLAGS += "-DFACILITY=LOG_DAEMON -DENABLE_DNS"
+CFLAGS += "-O2 -Wall -Wstrict-prototypes -fpie"
 
 fakeroot do_install() {
     install -d ${D}${mandir}/man8/ ${D}${base_sbindir} ${D}${sysconfdir}/init.d



             reply	other threads:[~2009-08-05  6:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05  6:22 Graham Gower [this message]
2009-08-09 13:30 ` [PATCH] fix portmap on mips, remove old slugos workaround Holger Hans Peter Freyther
2009-08-09 14:57   ` Mike Westerhof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A792519.20506@gmail.com \
    --to=graham.gower@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.