From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934136AbZHEKD1 (ORCPT ); Wed, 5 Aug 2009 06:03:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933243AbZHEKD1 (ORCPT ); Wed, 5 Aug 2009 06:03:27 -0400 Received: from gw1.cosmosbay.com ([212.99.114.194]:42639 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933165AbZHEKD0 (ORCPT ); Wed, 5 Aug 2009 06:03:26 -0400 Message-ID: <4A7958D3.40206@gmail.com> Date: Wed, 05 Aug 2009 12:02:59 +0200 From: Eric Dumazet User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: Frans Pop CC: Linux Kernel Mailing List , netdev@vger.kernel.org, Jiri Pirko Subject: Re: BUG: spinlock bad magic on CPU#1, swapper/1 References: <200908051136.44908.elendil@planet.nl> <200908051150.53301.elendil@planet.nl> In-Reply-To: <200908051150.53301.elendil@planet.nl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [0.0.0.0]); Wed, 05 Aug 2009 12:03:00 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Frans Pop a écrit : > On Wednesday 05 August 2009, Frans Pop wrote: >> Current v2.6.31-rc5-246-g90bc1a6 gives me: >> >> BUG: spinlock bad magic on CPU#1, swapper/1 >> lock: ffff88007e1889c8, .magic: 00000000, .owner: /-1, .owner_cpu: 0 >> Pid: 1, comm: swapper Not tainted 2.6.31-rc5 #4 >> Call Trace: >> [] spin_bug+0xa2/0xaa >> [] _raw_spin_lock+0x23/0x135 >> [] _spin_lock_bh+0x19/0x1e >> [] alloc_netdev_mq+0x127/0x211 >> [] ? netdev_init+0x6a/0xac >> [] ? loopback_setup+0x0/0x7b >> [] loopback_net_init+0x30/0x7a >> [] register_pernet_device+0x2b/0x58 >> [] net_dev_init+0x13d/0x19b >> [] ? net_dev_init+0x0/0x19b >> [] do_one_initcall+0x56/0x12b >> [] ? register_irq_proc+0xb0/0xcc >> [] ? proc_pid_cmdline+0x5a/0xf9 >> [] kernel_init+0x14d/0x1a3 >> [] child_rip+0xa/0x20 >> [] ? kernel_init+0x0/0x1a3 >> [] ? child_rip+0x0/0x20 >> >> Error occurs during early boot (between PCI/ACPI init and PnP init). > > Reverting the following commit fixes it: > commit a6ac65db2329e7685299666f5f7b6093c7b0f3a0 > Author: Jiri Pirko > Date: Thu Jul 30 01:06:12 2009 +0000 > > net: restore the original spinlock to protect unicast list > > There is a path when an assetion in dev_unicast_sync() appears. > > igmp6_group_added -> dev_mc_add -> __dev_set_rx_mode -> > -> vlan_dev_set_rx_mode -> dev_unicast_sync > > Therefore we cannot protect this list with rtnl. This patch restores the > original protecting this list with spinlock. > > Signed-off-by: Jiri Pirko > Tested-by: Meelis Roos > Signed-off-by: David S. Miller > -- Ingo posted a fix http://marc.info/?l=linux-kernel&m=124945666109347&w=2