From: Eric Miao <eric.y.miao@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] input: make matrix keymap size dynamic
Date: Wed, 05 Aug 2009 19:01:52 +0800 [thread overview]
Message-ID: <4A7966A0.6020903@gmail.com> (raw)
In-Reply-To: <20090805082631.96C1A526EA5@mailhub.coreip.homeip.net>
Dmitry Torokhov wrote:
> Hi Eric,
>
> On Tue, Aug 04, 2009 at 05:24:01PM +0800, Eric Miao wrote:
>> The number of rows and columns should really belong to 'struct keymap_data',
>> and assumption on the shift and size of rows/columns removed.
>>
>
> I aplayed with your patch for a while and moving rows and columns into
> struct keymap_data did not feel right; the changes to activate_cols and
> others where we have to access 2 different structures to get gpios and
> upper limit made the code awkward. In the end I decided the sizes should
> be kept where they were, together with the gpio arrays.
>
> What do you think about the modified version of your patch below? The
> definitions seem to be working for other matrix drivers I have i my
> queue as well...
>
Sure go. I'm quite happy with your approach.
prev parent reply other threads:[~2009-08-05 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 9:24 [PATCH] input: make matrix keymap size dynamic Eric Miao
2009-08-05 8:26 ` Dmitry Torokhov
2009-08-05 11:01 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7966A0.6020903@gmail.com \
--to=eric.y.miao@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.