From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Thu, 06 Aug 2009 13:12:11 -0500 Subject: [U-Boot] PLATFORM_CPPFLAGS ? Message-ID: <4A7B1CFB.3030905@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Why do we define the same macros in config.mk and in the board header file? config.mk: PLATFORM_CPPFLAGS += -DCONFIG_E500=1 PLATFORM_CPPFLAGS += -DCONFIG_MPC85xx=1 PLATFORM_CPPFLAGS += -DCONFIG_MPC8572=1 MPC8572DS.h: #define CONFIG_BOOKE 1 /* BOOKE */ #define CONFIG_E500 1 /* BOOKE e500 family */ #define CONFIG_MPC85xx 1 /* MPC8540/60/55/41/48 */ #define CONFIG_MPC8572 1 Isn't it redundant to have these entries in config.mk? We seem to be doing this more and more, but config.mk is always board-specific, just like MPC8572DS.h. -- Timur Tabi Linux kernel developer at Freescale