From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Tramnitz <chris.ace@gmx.net>
Subject: Re: [PATCH] fix ioemu build
Date: Fri, 07 Aug 2009 00:44:48 +0200
Message-ID: <4A7B5CE0.8080907@gmx.net>
References: <4A7B5366.7000400@gmx.net>
	<C6A11819.1191C%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C6A11819.1191C%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:
>> Anyway checking for the existence of a file before actually deleting it
>> shouldn't really hurt...
> 
> But... 'rm -f' doesn't fail when the file doesn't exist?

It doesn't, but under circumstances this is escaping the sandbox and 
generating an access violation.
This was initially reported for 3.3.1 as gentoo bug and fixed with this 
patch. Now I'm trying to get the live ebuilds working but patching is 
not an option there...

Details are available here:
http://bugs.gentoo.org/262124

Not really sure if this only manifests itself in the gentoo build 
environment, but since other places in xen-setup check for the existence 
of the file before doing sth with it, I don't think it would hurt to apply.


Btw, the path in my patch was wrong, I guess it should be 
qemu-xen-unstable instead of ioemu-dir.


Best regards,
   Christian